lance-format / lance-format/lance
rename `unloaded_mut` into `unload` that returns `&mut Unloaded`
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
Let's fix in a follow-up but this function should probably be called unload instead of unloaded_mut? If I see unloaded_mut I think of an accessor function returning &mut Unloaded or something like that.
Originally posted by @westonpace in https://github.com/lance-format/lance/pull/5752#discussion_r2742545020
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for unloaded_mut and inspect its definition and all call sites. Rename the function to unload, update references as needed, and run the relevant Rust tests or checks to confirm the project still builds and the rename is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100