lance-format / lance-format/lance

Set `JsonIndexParameters` to a pub structure or provide a construct function for it

Open
#5,311 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

https://github.com/lance-format/lance/blob/abce5a5a7c05d515c3b0edf6add3f95518390ecc/rust/lance-index/src/scalar/json.rs#L163-L169

Hi. I want to use Rust to build an index for a JSON column, but i found that the field of JsonIndexParameters is not pub. So i cannot use JsonIndexParameters to create the json index, only i can do is build ScalarIndexParams with str directly.

Can we set JsonIndexParameters to a pub structure or provide a construct function for it? It could be useful.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in rust/lance-index/src/scalar/json.rs at lines 163-169 and inspect how JsonIndexParameters is defined and used by ScalarIndexParams. Determine whether making the structure public or adding a constructor best enables Rust callers to create JSON indexes; done means callers can use the parameters without relying on a string directly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.