lance-format / lance-format/lance
Refactor: we should move `DatasetIndexExt` into the `lance` crate
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
As I was working on the describe indexes function this trait was kind of annoying because it is in the lance-index crate. The lance-index create shouldn't need to have any knowledge of the concept of a "dataset". I'm not sure we gain anything by having this here.
Dropping this here because I want to try and remember to address this after https://github.com/lancedb/lance/pull/5221 merges.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the DatasetIndexExt trait in the lance-index crate and the describe indexes work mentioned in the issue. Confirm the dependency on PR 5221, then trace the trait's uses before moving the dataset-specific responsibility into the lance crate; done means lance-index no longer knows about datasets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100