lance-format / lance-format/lance
Add `to_physical_stream` for lance
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
This is fine. In a perfect world I think maybe we would have something like...
fn to_physical_stream(&self, stream: SendableRecordBatchStream) -> PhysicalRecordBatchStream;
This way the compiler could make sure that we aren't accidentally using the logical stream in places we should be using the physical stream (or vice-versa).
However, we can think about this as a todo for now.
Originally posted by @westonpace in https://github.com/lancedb/lance/pull/5096#pullrequestreview-3412083068
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the stream-related entry points and the SendableRecordBatchStream and PhysicalRecordBatchStream types mentioned in the issue. Determine where to add to_physical_stream so logical and physical streams are distinguished, then verify that the conversion is available at the intended call sites.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- data-engineering
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100