lance-format / lance-format/lance

Lance library should ignore indices it doesn't know how to use

Open
#5,120 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

The existence of these carveouts suggest that we will error if we try to query with indices we don't support:

https://github.com/lancedb/lance/blob/9ed9ee2f9df69d54e7cb55a995728deb98e7a195/python/python/tests/forward_compat/test_compat.py#L69-L72

There are some properties we should validate in tests:

If a dataset contains an unsupported index:

  1. We can still scan and query the dataset
  2. We can still write to the dataset, and it will preserve the unsupported index
  3. We can still run optimize indices, and it will preserve the unsupported index
  4. We can drop the unsupported index

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with python/python/tests/forward_compat/test_compat.py, especially the linked carveout, and trace the dataset operations it exercises. Add coverage for scanning, querying, writing, optimize indices, and dropping a dataset containing an unsupported index; done means all five operations work and the index is preserved except when dropped.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.