lance-format / lance-format/lance
Make take_rows API public?
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
From discord discussion https://discord.com/channels/1030247538198061086/1105226935333818532/1379620602264162384
Users are actively using dataaset._take_rows, by retrieving row addresses from scanner with with_row_address=True and supplying that in to the API. Should we just make this public instead of internal?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Discord discussion and inspect the current dataaset._take_rows entry point, including how scanner results from with_row_address=True are supplied. The work is done when the project has a decided, supported public API boundary for this row-address workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100