lance-format / lance-format/lance

Setup a slow path/nightly build to test large tests

Open
#3,814 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

Right now there are ~10ish tests which are marked as ignore due to the long running time. However some of them are quite useful as they practice some extra large datasets. I suggest to setup a separate build to test them so that it's automated and prevents unexpected future bugs. Happy to help if people find it useful.

((.venv) ) ➜  rust git:(3515-test-read-logic) ✗ ack "#\[ignore"      
lance-io/tests/gcs_integration.rs
23:#[ignore = "Must be run manually on GCS"]
50:#[ignore = "Must be run manually on GCS"]

lance-encoding/src/encodings/physical/binary.rs
1092:    #[ignore] // This test is quite slow in debug mode

lance-encoding/src/encodings/physical/fixed_size_list.rs
196:    #[ignore]

lance-encoding/src/encodings/physical/fixed_size_binary.rs
283:    #[ignore] // This test is quite slow in debug mode

lance-encoding/src/encodings/physical/dictionary.rs
547:    #[ignore] // This test is quite slow in debug mode

lance-encoding/src/encodings/logical/list.rs
1900:    #[ignore] // This test is quite slow in debug mode

lance-encoding-datafusion/src/zone.rs
699:    #[ignore]

lance-index/src/scalar/bitmap.rs
448:    #[ignore]
((.venv) ) ➜  rust git:(3515-test-read-logic) ✗ ack "#\[ignore" | wc -l
      9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the nine ignored tests listed in the issue, including lance-io/tests/gcs_integration.rs and the lance-encoding, lance-encoding-datafusion, and lance-index test files. Review the repository's existing build and CI configuration, then determine how to run these tests separately from the normal suite. Done means the slow or nightly build runs them automatically without making the regular build wait for them.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.