lance-format / lance-format/lance

First transaction attempt should error on missing versions when checking for transaction conflicts

Open
#3,719 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

Currently, there is a special case during transaction conflict resolution to handle read errors due to missing versions and succeed.

This should be removed as the transaction may conflict with old versions which have been cleaned up. The transaction should fail instead.

https://github.com/lancedb/lance/blob/d5838ba9f1e38cc9fe030936f722a8dfb08d1d7d/rust/lance/src/io/commit.rs#L753

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read rust/lance/src/io/commit.rs around line 753 and trace the special case for read errors caused by missing versions during transaction conflict resolution. Done means the first transaction attempt reports a conflict when required old versions are missing, rather than succeeding through that special case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.