lance-format / lance-format/lance

Unify `storage_options`, URI params, and `ObjectStoreParams`

Open
#2,536 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

Right now, most options can be passed in either environment variables or storage_options argument. But there's some like ddbTableName that are passed down as URI parameters:

https://github.com/lancedb/lance/blob/63227f4e2755cddbc27b6046e03a0df0f06869c1/docs/read_and_write.rst?plain=1#L715-L717

To unify these, we could make the ddbTableName and related options available as storage_options. Then we could make all query parameters in URIs parsed as storage options. That would make the following two equivalent:

lance.dataset("s3://my-bucket/my-table", storage_options={"ddbCommitLock": "true", "ddbTableName": "myDdbTable"})
lance.dataset("s3://my-bucket/my-table?ddbCommitLock=true&ddbTableName=myDdbTable")

As part of this, we could simplify things by deprecating the s3+ddb scheme in favor of simply ddb.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/read_and_write.rst around the referenced URI-parameter example and the lance.dataset entry point, then trace storage_options, URI parsing, and ObjectStoreParams. Done means equivalent storage_options and URI forms support ddbTableName and related options, with the s3+ddb scheme deprecation addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
backend-api-design, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.