lance-format / lance-format/lance

aws-* dependency maintenance

Open
#2,511 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-deps rust
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

Building my Rust project with lancedb@0.5 with aarch64-pc-windows fails because this architecture isn't supported with ring@0.16 ^1, which is a dependency because lancedb | lance -> lance-index -> lance-io -> aws-config@0.56 -> ring@0.16. Support for aarch64-pc-windows is available in ring@0.17 ^2.

Potential fixes

  1. Updating aws-config

    #2510

    This PR bumps a minor version. However, the aws-* dependencies are depending on pre-release versions. The production-ready versions (1+) are now available. Maybe this is worth scheduling in #2079? (However, I'm guessing there are plenty of breaking changes.)

  2. Making the aws libs optional

    Could we make these dependencies optional by making them part of cargo feature named 'aws' for lance-io, lance-index, lance, and lancedb? I am not using AWS for my project, perhaps others aren't either.

    This feature could be enabled by default in lance and lancedb for backwards compatibility.

Workaround

In your Cargo.toml, add:

[patch.crates-io]
lance-io = { git = "https://github.com/nickdarvey/lance", branch = "patch-2" }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the dependency chain from lancedb through lance, lance-index, lance-io, aws-config, and ring. Review the dependency declarations for the four named crates and compare the proposed update in #2510 with the scheduling context in #2079. Done means the selected dependency or feature approach supports the reported architecture without breaking existing defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, rust
Domain
backend, build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.