lance-format / lance-format/lance
Clean up common tests for `external_manifest` and all the implementations
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
in #1205 we copied tests from io::commit::external_manifest. We did this because the four tests applies to all implementation of ExternalManifestStore. Move these tests to a common place for eaiser maintainance and resuability
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the tests copied in #1205 from io::commit::external_manifest and the ExternalManifestStore implementations. Identify a shared location for the four tests, move them there for reuse across all implementations, and verify that the implementations still pass the common test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100