lambertf917 / lambertf917/ride-sharing-solution-react

Negative Commission Rates Accepted

Open
#194 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
An issue has been identified in the Multivendor Admin Dashboard where the commission rates for vendors are accepting negative values.

To Reproduce
Steps to reproduce the behavior:

Log in to the Multivendor Admin Dashboard.
Navigate to the section where commission rates for vendors are configured.
Attempt to set a negative value for the commission rate.
Expected behavior
The system should prevent users from entering or saving negative values for commission rates, as negative rates are not valid in this context.

Screenshots
https://github.com/ninjas-code-official/food-delivery-multivendor/assets/152266796/1cbcd911-8f36-43bc-8de1-8498ea3b5a78

Desktop:

Browser: chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Multivendor Admin Dashboard and trace the vendor commission-rate configuration entry point. Verify the current behavior in Chrome, then confirm that negative commission values cannot be entered or saved and that valid rates still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.