lambertf917 / lambertf917/react-native-uber-eats-clone

Negative Commission Rates Accepted

Open
#2,101 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
An issue has been identified in the Multivendor Admin Dashboard where the commission rates for vendors are accepting negative values.

To Reproduce
Steps to reproduce the behavior:

Log in to the Multivendor Admin Dashboard.
Navigate to the section where commission rates for vendors are configured.
Attempt to set a negative value for the commission rate.
Expected behavior
The system should prevent users from entering or saving negative values for commission rates, as negative rates are not valid in this context.

Screenshots
https://github.com/ninjas-code-official/food-delivery-multivendor/assets/152266796/1cbcd911-8f36-43bc-8de1-8498ea3b5a78

Desktop:

Browser: chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start at the Multivendor Admin Dashboard's vendor commission-rate configuration, reproduce entering and saving a negative value, and trace the relevant validation; done means negative rates are prevented and the behavior has regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.