lambdaisland / lambdaisland/webstuff

The garden rules returned from Girouette need to be sorted

Open
#8 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
9
Forks
0
PR merge metrics
No merged PRs in 30d

Description

In Girouette v0.0.4, the garden rules returned by class-name->garden have some metadata which need to be used when deciding the order in which those rules need to be output in a CSS file.

This is how the processor tool of Girouette is accessing the ordering data and how it sort the rules:
https://github.com/green-coder/girouette/blob/v0.0.4/lib/processor/src/girouette/processor.clj#L172-L173

A similar sorting needs to be done in Ornament, to avoid the issue raised in https://github.com/green-coder/girouette/pull/66

Update: see my comment below.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the class-name->garden behavior in Ornament and compare its ordering metadata with the referenced Girouette v0.0.4 processor code at lines 172–173. Verify the generated CSS rules are sorted consistently with Girouette and check the issue's follow-up comment for the updated scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.