lambdaisland / lambdaisland/kaocha

Allow configuring skip-meta / focus-meta at the top level

Open
#47 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

first issue only help wanted improvement
Dominant language
Clojure
Stars
860
Forks
81
PR merge metrics
No merged PRs in 30d

Description

Currently the skip/focus configuration is part of the test suite. I think at least for the -meta versions we should also allow configuring them at the top level configuration.

This already kind of works, you can use kaocha.filter/focus-meta or kaocha.filter/skip-meta, but it's undocumented, and the shorthand versions only work in the test suite (:focus-meta and :skip-meta).

Also currently if either is specified on the command line then it will overrule what's configured, this is fine for --focus-meta I think, but not for --skip-meta, which should be additive.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace how top-level configuration, test-suite configuration, and command-line options reach kaocha.filter/focus-meta and kaocha.filter/skip-meta. Compare the existing :focus-meta and :skip-meta shorthand handling; done means both meta filters can be configured at the top level, with command-line focus overriding configuration and command-line skip adding to it.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
cli, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.