lambdaisland / lambdaisland/kaocha-cljs2

timeout not respected in all cases

Open
#31 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Clojure
Stars
34
Forks
8
PR merge metrics
No merged PRs in 30d

Description

hello. in the config you can specify :kaocha.cljs2/timeout xxx and that gets passed through to the funnel client listen! function https://github.com/lambdaisland/kaocha-cljs2/blob/main/src/kaocha/cljs2/funnel_client.clj#L53 for the 'load' of the tests from the initial config. when it comes to the next stage of loading - getting tests from the clients, the timeout is not passed on - it is nil.

Note. this description ^^^ might not be quite right. the process of loading and running in kaocha is not completely clear to me. but the first time listen! is called the timeout is there, and the next time it is nil - that I can say for sure

so... in an attempt to get my suites passing I have changed this line in my branch https://github.com/henryw374/kaocha-cljs2/blob/main/src/kaocha/type/cljs2.clj#L99 - to call add-timeouts before the load. this seems to work...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the timeout passed to listen! in src/kaocha/cljs2/funnel_client.clj around line 53, then trace the later client-loading path in src/kaocha/type/cljs2.clj around line 99. Compare the existing placement of add-timeouts with the two listen! calls and verify that the configured timeout remains present during subsequent test loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.