lambdaisland / lambdaisland/kaocha-cljs

ClojureScript incompatible with tools.reader 1.3.1/1.3.2

Open
#13 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Clojure
Stars
47
Forks
10
PR merge metrics
No merged PRs in 30d

Description

This is strictly an upstream issue, but posting it here since people might run into it and come looking for a solution.

https://clojure.atlassian.net/browse/CLJS-3097

Long story short: tools.reader changed the two-arity version of read+string to be in line with read+string in clojure.core

;; before
(read+string reader opts)

;; now
(read+string opts reader)

And this is used by the clojurescript prepl, which we rely on. So for the time being you have to stick to tools.reader 1.3.0.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the upstream CLJS-3097 report and the ClojureScript prepl entry point described here; compare its two-arity read+string call with tools.reader 1.3.0, 1.3.1, and 1.3.2. The issue does not define a repository change or test for completion; it currently documents pinning tools.reader 1.3.0 as the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.