lambdaisland / lambdaisland/deep-diff2

Minimize removes all newly added/removed collection items under newly added/removed map keys

Open
#52 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
326
Forks
18
PR merge metrics
No merged PRs in 30d

Description

(ddiff/diff {:a 1} {:a 1 :items [{:x 3}]})
=> {#lambdaisland.deep_diff2.diff_impl.Insertion{:+ :items} [{:x 3}], :a 1}

(->> (ddiff/diff {:a 1} {:a 1 :items [{:x 3}]})
       (ddiff/minimize))
=> {#lambdaisland.deep_diff2.diff_impl.Insertion{:+ :items} []}


So all such big differences are hidden.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the examples with ddiff/diff and then pass the result to ddiff/minimize. Trace how minimize handles an insertion under the newly added :items map key; done means the nested collection item remains visible in the minimized result instead of becoming an empty vector.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.