lambdaclass / lambdaclass/lambda_ethereum_consensus
Add tests for blobs and blocks p2p interface
Open
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 109
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
We had a regression when getting blobs through gossip fixed in #1443 that could have been avoided if we had some tests. We should add tests for the whole block and blob download process. Right now we have a test that is testing some of it but is currently skipped in this file
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the skipped test in test/unit/pending_blocks.exs and review the regression fixed in #1443. Trace the existing coverage for blob and block downloads through gossip, then add tests covering the whole p2p download process; done means the relevant download paths are exercised without skipped coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- networking, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100