lambdaclass / lambdaclass/lambda_ethereum_consensus
Aggregation discards sync committee messages/attestations on delays when subnet wasn't created
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 109
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
This issue is a follow-up of #1301, that issue is fixed right now, receiving messages before having the subnet created doesn't crash LibP2P anymore, we just discard them. The Subnet info data structure is create at the time of attesting or broadcasting a sync committee message, in the second third of the slot, some delays could make some messages being lost on aggregations, this could probe to be an issue in some not-so-common cases where we skip the second third altogether due to a delay and go directly to the aggregation step which in our case would be empty even when we actually received messages and attestations.
This is not a priority be we should be mindful of this in case we encounter the issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Trace the subnet-info creation used during attesting or sync committee broadcasting, then follow the aggregation step for delayed slots; done means received messages and attestations are not lost when the second third is skipped or the subnet is created late.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100