lambdaclass / lambdaclass/lambda_ethereum_consensus
Make tests run without --no-start
Nobody has claimed this yet.
- Dominant language
- Elixir
- Stars
- 109
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Description
Currently we have different configuration categories:
- mode: db vs full.
:dbdoesn't enable the metadata genserver, the beacon api or the beacon node, which contains the fork choice genserver, libp2p features, the beacon chain genserver, etc. - genesis_strategy: were to get the first state from: checkpoint sync, a .ssz file, or the db.
Unit tests are mostly functional, and run with --no-start, so they currently patch interactions with the beacon chain so that libp2p doesn't activate, sync with others in a public network, etc. However, the client is configurable enough for us to be able to run the actual node in the tests and avoid patching and mocking behavior. In that way we both should increase coverage and stop hiding errors in tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the test setup around --no-start and the mode and genesis_strategy configuration. Identify the tests currently patching beacon-chain interactions, then verify they run with the actual node and no longer hide startup or networking errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elixir
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100