lambdaclass / lambdaclass/lambda_compiler_kit
refactor: remove asymmetry between singleton and cons in ValidJsonArray
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem
ValidJsonArray has separate singleton and cons constructors, creating asymmetry. A uniform nil / cons inductive pattern would be simpler and more consistent with standard list-shaped inductives in Lean/Mathlib.
Expected fix
Refactor ValidJsonArray to use a uniform nil/cons structure. Verify that all downstream proofs (Proofs.lean) still hold with the refactored definition.
References
- Suggested by AI code review on PR #8
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ValidJsonArray definition and read Proofs.lean to identify all downstream uses and proof obligations. Refactor the structure to a uniform nil/cons form, then verify that the existing proofs still compile and hold.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100