lambdaclass / lambdaclass/lambda_compiler_kit
refactor: rename ParseError.canonicalizationError to duplicateKeyError
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem
ParseError.canonicalizationError is the error returned when rejectDuplicates finds a duplicate key. The name canonicalizationError is vague and misleading — canonicalization normally means normalization to a canonical form, not rejection.
Expected fix
Rename to ParseError.duplicateKeyError (or duplicateKey) for clarity. Update all match arms and documentation.
References
- Flagged by AI code review on PR #8
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for ParseError.canonicalizationError and inspect its definition, match arms, and documentation references. Rename the symbol to duplicateKeyError or duplicateKey consistently, then verify that no old references remain and the existing checks pass.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100