lambdaclass / lambdaclass/eth-agent

RPC client retries permanent failures (DNS, auth errors)

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug critical
Dominant language
TypeScript
Stars
10
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Problem

All non-RPC errors trigger retries, but some network errors (DNS failures, invalid URLs) should not be retried.

Location

src/protocol/rpc.ts:102-117

Current Code

if (err instanceof RPCRequestError) {
  throw err;  // Don't retry RPC errors
}
// All other errors retry - including permanent failures
if (attempt < this.retries) {
  await sleep(this.retryDelay * (attempt + 1));
}

Recommendation

  • Classify errors (transient vs permanent)
  • Don't retry: DNS errors, invalid URL, auth failures
  • Do retry: connection reset, timeout, 5xx errors

Priority

Critical - Correctness

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/protocol/rpc.ts:102-117 and trace how errors reach the retry decision. Classify DNS failures, invalid URLs, and authentication failures as non-retryable, while preserving retries for connection resets, timeouts, and 5xx errors; done means each category follows the requested retry behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.