lambdaclass / lambdaclass/eth-agent
ENS name validation incomplete - doesn't follow ENSIP-15
Open
Nobody has claimed this yet.
bug
medium-priority
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem
ENS name handling appends .eth if name doesn't end with it or contain dots, but doesn't validate for malicious inputs or follow ENSIP-15 normalization.
Location
src/protocol/ens.ts:29-31
Current Code
if (!name.endsWith('.eth') && !name.includes('.')) {
name = \`\${name}.eth\`;
}
Recommendation
- Validate name against ENS specification (ENSIP-15 normalization)
- Handle punycode/unicode normalization properly
- Reject clearly invalid names early
Priority
Medium - Input validation/Security
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/protocol/ens.ts:29-31 and compare the current .eth-appending behavior with ENSIP-15. Check the required punycode and Unicode normalization rules, then define handling for clearly invalid or malicious names. Done means ENS names are normalized and invalid inputs are rejected early.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100