lambdaclass / lambdaclass/eth-agent
Approval flow has no timeout - can hang indefinitely
Open
Nobody has claimed this yet.
bug
medium-priority
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem
Approval request has no timeout. If approval handler never responds, transaction hangs indefinitely.
Location
src/agent/wallet.ts:323-339
Recommendation
- Add configurable timeout to approval flow
- Throw ApprovalTimeoutError when exceeded
- Default to reasonable timeout (e.g., 5 minutes)
Priority
Medium - UX/Reliability
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/agent/wallet.ts:323-339, where the approval flow is located, and trace how approval requests are initiated and resolved. Define the configurable timeout and default behavior, then verify that an unresponsive handler produces ApprovalTimeoutError and that normal approvals still complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100