lambdaclass / lambdaclass/eth-agent
TransactionBuilder should use 'this' return type for proper chaining
Open
Nobody has claimed this yet.
enhancement
high-priority
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Problem
Builder methods likely don't preserve type information for chaining with subclasses.
Location
src/protocol/transaction.ts
Recommendation
- Use
thisreturn type for all builder methods - Enables proper subclass chaining
- TypeScript best practice for builder pattern
Priority
High - Limits extensibility
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/protocol/transaction.ts by locating TransactionBuilder and reviewing each builder method's return type. Update the builder methods to use the this return type so subclasses preserve chaining types, then verify that the TypeScript project still type-checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100