labthings / labthings/labthings-picamera2
Should CCM be an action or a property
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Setting the colour correction matrix requires restarting the camera. It may be that this means CCM should not be a writeable property. A read-only property based on the Control (i.e. previous implementation) combined with an action to set a static CCM might be the most consistent way of doing this.
Resetting the CCM should probably also restore the whole default tuning, rather than a single static CCM, but this isn't a major problem for now.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing CCM property and its Control implementation, focusing on the restart requirement when setting the colour correction matrix. Decide whether CCM should be read-only with a separate action, and define whether reset restores only the static CCM or the whole default tuning; done means the API design and reset behavior are unambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fastapi, python
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100