labthings / labthings/labthings-fastapi

Possible race condition in tests

Open
#340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
9
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

An inconsistent Invocation (status=="completed" but no completion time) was seen in the test suite. See https://github.com/labthings/labthings-fastapi/actions/runs/25758699258/job/75653918308?pr=339

Additional context

I suspect this means something is not using the invocation status lock properly. It's a minor issue but one to fix at some point if this is the case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the test-suite failure in the linked GitHub Actions run and trace how Invocation status and completion time are updated. Determine whether the invocation status lock covers both values, then reproduce the inconsistency and add or update a regression test so completed invocations always have a completion time.

Written by the indexing model from the issue text.

Assessment

Tech stack
fastapi, python
Domain
backend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.