labthings / labthings/labthings-fastapi
[Testing] Need integration tests or higher level tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
In playing round with return types I accidentally set all returns from ThingClient as None.
The only tests that errored were the ones for blobs. While the coverage is high, there probably needs to be another test suite with some more high level tests. Basically a simple simulation application which handles things like Things calling eachother, calling things over HTTP, something a bit more complex than in a unit test.
This will also help with checking that projects using LabThings can be typed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the return-type regression and reviewing the existing blob tests, which were the only tests that failed. Then map the proposed higher-level suite around a small simulation involving Things calling each other and communicating over HTTP. Done means the suite exercises these interactions and catches return-type failures that unit tests miss.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fastapi, python
- Domain
- backend-api-design, testing
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100