Error when `NewClaimsFunc` returns value object
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 124
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Edit the sample below so that NewClaimsFunc returns a value object.
https://echo.labstack.com/docs/cookbook/jwt
NewClaimsFunc: func(c echo.Context) jwt.Claims {
return jwtCustomClaims{}
},
The following error occurs.
token is malformed: could not JSON decode claim: json: cannot unmarshal object into Go value of type jwt.Claims
I think it would be a good idea to add a check to see if Claims is a pointer.
Below is an example of a json package.
https://cs.opensource.google/go/go/+/refs/tags/go1.22.2:src/encoding/json/decode.go;l=172-175
I also think it would be effective to add this to the NewClaimsFunc documentation.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the JWT cookbook sample at https://echo.labstack.com/docs/cookbook/jwt and inspect how NewClaimsFunc is documented and used. Reproduce the value-object error, then determine whether the sample and NewClaimsFunc documentation should be updated; done means the documented usage no longer leads to the reported decode error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100