Sometimes https is not working for new site
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.7k
- Forks
- 64
- PR merge metrics
- No merged PRs in 30d
Description
I have issue, that after some time, Armor won't issue TLS certificate for newly entered site in config.json.
Only way to get around this issue is to completely delete cache_tls file, and to start again.
Another problem is, that I don't see that error in my Armor log file.
I am on Windows, and I am calling Armor from BAT file like so:
armor -c config.json >> armor.log
And this is working perfectly, but TLS error messages were not written into file. I see those messages only when I run armor.exe in terminal window:
⇛ https server started on
2016/11/17 11:27:42 http: TLS handshake error from 72.66.115.14:52280: unknown host
2016/11/17 11:27:45 http: TLS handshake error from 72.66.115.14:58976: unknown host
2016/11/17 11:27:45 http: TLS handshake error from 72.66.115.14:58977: unknown host)
But in my armor.log I don't see those messages, only JSON log lines are showed:
{"time":"2016-11-17T11:29:42+01:00","remote_ip":"192.168.1.3","host":"","method":"GET","uri":"timeline","status":200, "latency":2131000,"latency_human":"2.131s","bytes_in":0,"bytes_out":86578}
{"time":"2016-11-17T11:29:42+01:00","remote_ip":"192.168.1.3","host":"","method":"GET","uri":"chrome.ico","status":200, "latency":55000,"latency_human":"55ms","bytes_in":0,"bytes_out":3638}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue on Windows using armor.exe, config.json, a newly entered site, cache_tls, and BAT-file output redirected to armor.log. Compare terminal output with armor.log, focusing on TLS certificate issuance and the missing TLS handshake errors; done means the new site receives its certificate and those errors are recorded in the log.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, observability, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100