lablup / lablup/backend.ai

Apply try-with-resources pattern in LablupPatches.java

Open
#7,029 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
670
Forks
183
Avg merge
17h 7m
Merged PRs (30d)
358

Description

## Problem

`BufferedReader` and `InputStreamReader` are not properly closed, which could lead to resource leaks.

## Affected Files

- `src/ai/backend/kernel/java/LablupPatches.java:44-45`
- `src/ai/backend/kernel/java/LablupPatches.java:29`

## Scanner Reference

- **Sparrow**: RESOURCE_LEAK - Issues #919, #920, #921

## Recommended Fix

Use try-with-resources pattern:

```java
// Before
BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()));
// ... use reader ...
// reader may not be closed on exception

// After
try (BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()))) {
// ... use reader ...
} // automatically closed
```

JIRA Issue: BA-3204

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.