lablup / lablup/backend.ai

Improve client SDK's missing parts and mistakes

Open
#3,207 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
670
Forks
183
Avg merge
17h 7m
Merged PRs (30d)
358

Description

There are several issues found when I tried to use the client SDK for model services and @leksikov tried to write Helmsman training dataset for the model service CLI.

Regarding #3202, there is a general problem with existing `ComputeSession` and `InferenceSession` classes with `from_session_id()` classmethod. Since the instance returned by `from_session_id()` does not have any other valid attributes before making an actual `GET /session/{session_name_or_id`} manager API request, trying to access `.service_ports`, `.session_name` would fail. As they are just plain `self` attributes and we cannot make `property` methods asynchronous, we should add an explicit async method to _fill_ the instance attributes.

### Related pull requests

- #2806

JIRA Issue: BA-17

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.