Remove incorrect GQL suffix from shared adapter methods and DTO classes
- Dominant language
- Python
- Stars
- 670
- Forks
- 183
- Avg merge
- 21h 49m
- Merged PRs (30d)
- 404
Description
The GQL suffix naming convention (from api/gql/CLAUDE.md) was incorrectly applied to shared adapter methods and DTO classes that are used by both GQL and REST v2 layers.
Affected adapter methods (in api/adapters/rbac.py):
- admin_search_roles_gql → admin_search_roles
- admin_search_role_assignments_gql → admin_search_role_assignments
- admin_search_permissions_gql → admin_search_permissions
- admin_search_entities_gql → admin_search_entities
- _convert_role_filter_gql → _convert_role_filter
- _convert_role_orders_gql → _convert_role_orders
- _role_gql_pagination_spec → _role_pagination_spec
Affected DTO classes (in common/dto/manager/v2/rbac/request.py):
- AdminSearchRolesGQLInput → AdminSearchRolesInput
- AdminSearchRoleAssignmentsGQLInput → AdminSearchRoleAssignmentsInput
- AdminSearchPermissionsGQLInput → AdminSearchPermissionsInput
- AdminSearchEntitiesGQLInput → AdminSearchEntitiesInput
The GQL suffix rule should only apply to Strawberry GraphQL types (e.g. DomainGQL, RoleFilterGQL), not to shared DTOs or adapter methods.
Files to update: adapter, REST handler, GQL resolvers, GQL types, SDK client, CLI commands, and tests (~15 files).
Originated from PR #10794 review comment.
JIRA Issue: BA-5598
Contributor guide
Research direction
Start in api/adapters/rbac.py and common/dto/manager/v2/rbac/request.py, then trace references through the REST handler, GQL resolvers and types, SDK client, CLI commands, and tests named in the issue. Rename the shared methods and DTOs consistently while retaining GQL suffixes only for Strawberry GraphQL types; done means all affected references and tests use the corrected names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql, python
- Domain
- api, backend-api-design, cli, testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 54/100