labgrid-project / labgrid-project/labgrid

Fix SSHManager cleanup exceptions during tests on NixOS

Open
#734 0 comments 0 reactions 1 assignee View on GitHub

@Emantor is already working on this.

Since Feb 17, 2021.

enhancement tests
Dominant language
Python
Stars
528
Forks
278
Avg merge
2d 19h
Merged PRs (30d)
4

Description

NixOS does not have ssh available within the build environment when running the tests, the following error is subsequently raised:

=============== 201 passed, 31 skipped, 27 deselected in 36.30s ================
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} child has vanished
Finished executing pytestCheckPhase

We should ensure that we cleanup test connections ourselves in the tests, so the global cleanup function doesn't catch those.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.