l3montree-dev / l3montree-dev/devguard
Wrong dependency proxy URLs on app.devguard.org
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 161
- Forks
- 43
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 37
Description
The dependency proxy URLs at
- organization level at
https://app.devguard.org/<org>/settings/dependency-proxy, - project level at
https://app.devguard.org/<org>/projects/<project>/settings/dependency-proxy, and - asset level at
https://app.devguard.org/<org>/projects/<project>/assets/<asset>/settings/dependency-proxy
all show https://api.main.devguard.org/api/v1/dependency-proxy/ as base url. I guess this should be https://api.devguard.org/api/v1/dependency-proxy/ instead.
It seems like this is because the env var DEPENDENCY_PROXY_BASE_URL is not set, hence it falls back to api.main.devguard.org as hostname, see https://github.com/l3montree-dev/devguard/blob/v1.13.3/controllers/dependencyfirewall/controller.go#L214-L217.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with controllers/dependencyfirewall/controller.go at lines 214-217 and inspect how DEPENDENCY_PROXY_BASE_URL is resolved. Verify the generated URLs at the organization, project, and asset dependency-proxy settings pages; done means each uses https://api.devguard.org/api/v1/dependency-proxy/ rather than the api.main.devguard.org fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100