kworkflow / kworkflow/patch-hub
Streamline `message_id` and `in_reply_to` fields of `Patch` struct
Open
Nobody has claimed this yet.
code-improv
refactoring
- Dominant language
- Rust
- Stars
- 36
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Context:
The message_id and in_reply_to fields of Patch are of type MessageID and Option<MessageID>, respectively.
Proposal:
Maybe we can streamline the implementation by flatting these fields as String and Option<String>. We need to consider if there will be scenarios in which having a dedicated type for MessageID will be necessary.
Setup:
- Project branch: unstable
- Project commit hash: 0fb93dbb5bc204cfe5342aca0d87e6bc679fca2f
rustcversion: 1.79.0cargoversion: 1.79.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the Patch struct and the MessageID type, then trace usages of message_id and in_reply_to across the project. Determine whether MessageID provides behavior that String cannot replace, and document or implement the chosen field types while keeping all affected uses consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100