kworkflow / kworkflow/patch-hub

`cargo install --path .` on 'master' no longer compiles with newer Rust toolchains

Open Beginner friendly
#195 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
36
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Description:

Running cargo install --path . no longer compiles due to mismatched-lifetime-syntaxes being triggered.

How to reproduce:

run cargo install --path . with updated rust toolchain.

Expected behavior:

To compile.

Screenshots
error: hiding a lifetime that's elided elsewhere is confusing
  --> src/ui/edit_config.rs:67:30
   |
67 | pub fn mode_footer_text(app: &App) -> Vec<Span> {
   |                              ^^^^         ^^^^ the same lifetime is hidden here
   |                              |
   |                              the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
   = note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
help: use `'_` for type paths
   |
67 | pub fn mode_footer_text(app: &App) -> Vec<Span<'_>> {
   |                                               ++++

error: hiding a lifetime that's elided elsewhere is confusing
  --> src/ui/edit_config.rs:76:23
   |
76 | pub fn keys_hint(app: &App) -> Span {
   |                       ^^^^     ^^^^ the same lifetime is hidden here
   |                       |
   |                       the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
76 | pub fn keys_hint(app: &App) -> Span<'_> {
   |                                    ++++

error: hiding a lifetime that's elided elsewhere is confusing
  --> src/ui/latest.rs:70:30
   |
70 | pub fn mode_footer_text(app: &App) -> Vec<Span> {
   |                              ^^^^         ^^^^ the same lifetime is hidden here
   |                              |
   |                              the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
70 | pub fn mode_footer_text(app: &App) -> Vec<Span<'_>> {
   |                                               ++++

error: hiding a lifetime that's elided elsewhere is confusing
  --> src/ui/mail_list.rs:53:30
   |
53 | pub fn mode_footer_text(app: &App) -> Vec<Span> {
   |                              ^^^^         ^^^^ the same lifetime is hidden here
   |                              |
   |                              the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
53 | pub fn mode_footer_text(app: &App) -> Vec<Span<'_>> {
   |                                               ++++

error: could not compile `patch-hub` (bin "patch-hub") due to 4 previous errors
Setup:
  • Project branch: master
  • Project commit hash: deba389

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running cargo install --path . with an updated Rust toolchain to reproduce the warnings. Review the affected signatures in src/ui/edit_config.rs, src/ui/latest.rs, and src/ui/mail_list.rs, then verify that the project compiles successfully with the same command and no mismatched-lifetime-syntaxes errors remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.