kwea123 / kwea123/nerf_pl

Why does eval.py only supports scene 'brandenburg_gate"?

Open
#217 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
2.8k
Forks
458
PR merge metrics
No merged PRs in 30d

Description

On line 169, there is if-else statement (if scene == 'brandenburg_gate':) that occurs error unless the given scene is brandenburg gate.

I erased this line for testing other scene, but i wonder why you did this.

Could you explain about this clause?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read eval.py around line 169 and trace how the scene argument reaches the if-else clause. Reproduce the error with a scene other than brandenburg_gate, then document the clause's purpose and the expected behavior for other scenes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
computer-vision, machine-learning
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.