kurusugawa-computer / kurusugawa-computer/annofab-api-python-client
[REQ][feature] `generated_api.py`で定義されている関数の`queyr_params`や`request_body`引数などは、`kw_only`にする
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 11
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
背景
もともとのコードでは、put_annotation関数に位置引数でrequest_bodyを渡していた。
annofabapiをバージョンアップしたら、put_annotationにquery_params引数が、reuqest_body引数の前に追加された。
したがって、今までのコードだと、request_bodyに渡していた内容がquery_paramsに渡されてしまい、期待していないエラーが発生した。
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in generated_api.py and inventory the functions exposing query_params or request_body, using the reported positional-argument failure as the motivating case. Make the affected arguments keyword-only and confirm that the generated client no longer accepts them positionally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100