kubesphere / kubesphere/s2ioperator

s2i build image token issue

Open
#168 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
47
Forks
60
PR merge metrics
No merged PRs in 30d

Description

hello all

start to set the s2i to build the image and ,set the token in this process. and we see it just add the path url in the remote webhook url.as below:
http://s2ioperator-trigger-service.kubesphere-devops-system.svc:8081/s2itrigger/v1alpha1/general/namespaces/gitlab/s2ibuilders/s21-python-latest-jpx/?secretCode=123456789

and in the gitlab we also find in the webhook , it also has the secret token in the page
![image](https://user-images.githubusercontent.com/40968187/164643876-b911e131-81b7-450e-8c40-347d1927cd2f.png)

however , maybe it not same function . gitlab will put the secret in the X-Gitlab-Token HTTP header. not in the url path 。
so , if it will be update to match the gitlab secret token function .

use the token in the process. it just put the token in the url and gitlab also need to add the full url in the webhook with token .
it‘not different without token.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the s2i build webhook flow and GitLab's X-Gitlab-Token behavior first. Confirm how the secretCode URL parameter is generated and validated, then define done as a webhook request with the GitLab header being handled as the configured secret without requiring the token in the URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
gitlab, go, kubernetes
Domain
ci-cd, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.