kubesphere / kubesphere/ks-devops

Unnecessary event record

Open
#653 0 comments 1 reaction 0 assignees View on GitHub
kind/bug
Dominant language
Go
Stars
164
Forks
140
PR merge metrics
No merged PRs in 30d

Description

### What is version of KubeSphere DevOps has the issue?

v3.3.0-rc.1

### How did you install the Kubernetes? Or what is the Kubernetes distribution?

_No response_

### What happened?

https://github.com/kubesphere/ks-devops/blob/master/controllers/jenkins/pipelinerun/pipelinerun_controller.go#L167
```go
func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
...
r.recorder.Eventf(pipelineRunCopied, corev1.EventTypeNormal, v1alpha3.Updated, "Updated running data for PipelineRun %s", req.NamespacedName)

return ctrl.Result{RequeueAfter: 3 * time.Second}, nil
}
```
When the pipelinerun does not reach the final phase (Succeeded or Fail), it will keep updating the event and never stop.

### Relevant log output

_No response_

### Additional information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start at controllers/jenkins/pipelinerun/pipelinerun_controller.go around line 167 and inspect the Reconcile path for nonterminal PipelineRun phases. Verify the event behavior while a PipelineRun remains running, then confirm that events are no longer repeatedly updated before the Succeeded or Fail phase.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend, devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.