kubesphere / kubesphere/ks-devops
Request to add admission webhook for PipelineRun CRD
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 164
- Forks
- 140
- PR merge metrics
- No merged PRs in 30d
Description
Why we need it
We can define two types of admission webhooks, validating admission webhook and mutating admission webhook. Mutating admission webhooks are invoked first, and can modify objects sent to the API server to enforce custom defaults. After all object modifications are complete, and after the incoming object is validated by the API server, validating admission webhooks are invoked and can reject requests to enforce custom policies.
So mutating admission webhook can do set some default values for our PipelineRun CR, like owner references and some labels. And validating admission webhook can do validate some fields of PipelineRun CR.
/kind feature
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked Kubernetes admission webhooks documentation and locating the PipelineRun CRD and its API-server integration in this repository. Clarify which default values and validation rules are required, then identify the relevant tests or add a test plan that demonstrates both mutating and validating behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100