kubesphere / kubesphere/ks-devops

Request to add admission webhook for PipelineRun CRD

Open
#258 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

kind/feature
Dominant language
Go
Stars
164
Forks
140
PR merge metrics
No merged PRs in 30d

Description

Why we need it

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#admission-webhooks

We can define two types of admission webhooks, validating admission webhook and mutating admission webhook. Mutating admission webhooks are invoked first, and can modify objects sent to the API server to enforce custom defaults. After all object modifications are complete, and after the incoming object is validated by the API server, validating admission webhooks are invoked and can reject requests to enforce custom policies.

So mutating admission webhook can do set some default values for our PipelineRun CR, like owner references and some labels. And validating admission webhook can do validate some fields of PipelineRun CR.

/kind feature

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked Kubernetes admission webhooks documentation and locating the PipelineRun CRD and its API-server integration in this repository. Clarify which default values and validation rules are required, then identify the relevant tests or add a test plan that demonstrates both mutating and validating behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.