kubernetes / kubernetes/perf-tests
Stop relying on unstructured data in network performance KPI codebase
- Dominant language
- Go
- Stars
- 989
- Forks
- 654
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 56
Description
**What would you like to be added**:
Instead of operating on Unstructured items, we want to define our type the same way built-in APIs are defined,
Example:
https://github.com/kubernetes/sample-controller/blob/master/pkg/apis/samplecontroller/v1alpha1/types.go
In network_performance_measurement.go , we have a CR NetworkTestRequest update events being received.
These objects need to be handled using defined types , but instead of unstructured items.
**Why is this needed**:
Operating on unstructured (if not needed), isn't a good pattern - this code would be much simpler if operating on the type itself.
Contributor guide
Research direction
Start with network_performance_measurement.go and inspect how NetworkTestRequest update events are currently received and handled as unstructured items. Compare the type definitions and event-handling approach in the linked sample-controller types.go. Done means NetworkTestRequest uses defined API types instead of unstructured items throughout this flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100