kubernetes / kubernetes/perf-tests

Prometheus snapshot not created when kubetest times out

Open
#1,086 5 comments 0 reactions 0 assignees View on GitHub
area/clusterloader lifecycle/frozen priority/important-soon
Dominant language
Go
Stars
989
Forks
654
Avg merge
3d 12h
Merged PRs (30d)
56

Description

Prometheus snapshot is not created if kubetest times out. Snapshotting logic lives inside clusterloader, so when kubetest times out the logic is simply not executed. It is unfortunate, especially timeouts are situation, which we'd like to debug usually.

I was hit by this issue when tryring to debug: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/88342/pull-kubernetes-e2e-gce-large-performance/1230477531426066432/

I see two options: 1) move snapshotting outside of the test (e.g. similarly to log dumping) 2) reconsider using Cortex (or any other solution that allows live recording of metrics).

@mm4tt - WDYT?

/priority important-soon
/area clusterloader

Contributor guide

Open the contributing guide

Research direction

Start by examining the snapshotting logic in clusterloader and compare its execution path with log dumping, especially when kubetest times out. Decide whether snapshotting should move outside the test or use a live-recording approach; done means a Prometheus snapshot is available after a timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes, prometheus
Domain
observability, performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.