kubernetes / kubernetes/kubectl
Follow up on splitting Flags from Option on annotate command
Open
kind/cleanup
lifecycle/rotten
needs-triage
priority/backlog
- Dominant language
- Go
- Stars
- 3.3k
- Forks
- 1k
- PR merge metrics
- No merged PRs in 30d
Description
Following up on https://github.com/kubernetes/kubectl/issues/1276, we need some more refinement based on the review from @ardaguclu on https://github.com/kubernetes/kubernetes/pull/112817. Basically:
* Move DryRunStrategy and DryRunVerifier from flags to options
* Write Unit tests for https://github.com/kubernetes/kubernetes/pull/112817/files#diff-9ccf80373137694902ef1403ddc2640d3511785056ff8ee07292611b95bdcdffR268-R286
* Write some integration tests in here: https://github.com/kubernetes/kubernetes/tree/534f052a8dfdd7b5861ee60d764d12da199c3bba/test/cmd
Contributor guide
Assessment
This issue has not been assessed yet.