kubernetes / kubernetes/kubectl

Umbrella Issue: refactor commands to split flags from options

Open
#1,046 37 comments 0 reactions 9 assignees Assigned to @soltysh View on GitHub
kind/feature lifecycle/frozen needs-triage priority/important-longterm
Dominant language
Go
Stars
3.3k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Currently most or even all of the commands have an `*Options` structure holding all of the data needed to run a command and three main methods `Complete` (finishing `*Options` struct), `Validate` (validating `*Options` struct) and `Run` (actual code behind the command). The current problem is that these `*Options` struct is tightly coupled with flags, but we'd like to split these.

A perfect example is [wait command](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go).

This issue should serve as a synchronization point.

/cc @eddiezane @seans3

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.