kubernetes / kubernetes/cloud-provider-aws
Support managing multiple tagged security groups for a node
- Dominant language
- Go
- Stars
- 465
- Forks
- 393
- Avg merge
- 22h 25m
- Merged PRs (30d)
- 11
Description
**What would you like to be added**:
Add support for managing multiple tagged security groups for a node.
**Why is this needed**:
At the moment we don't support finding and managing multiple tagged SecurityGroups per node (only one), and when we find more than one we error (ref code [here](https://github.com/kubernetes/cloud-provider-aws/blob/c9fbfe2bd46ab843655ec14f47021e4766a9c24b/pkg/providers/v1/aws.go#L4533)).
As such if a node has 2 or more tagged SecurityGroups we would fail to modify them in order to allow inbound traffic from the LB SecurityGroup.
Is there anything preventing us to extend this functionality to more than one tagged SecurityGroup?
If not, would it be possible to consider implementing it?
Thanks
/kind feature
Contributor guide
Research direction
Start in pkg/providers/v1/aws.go at the referenced security-group handling code, and trace how tagged SecurityGroups are found and modified for a node. Confirm the existing behavior when more than one tagged group is found; done means multiple tagged groups can be managed so inbound traffic from the load balancer SecurityGroup is allowed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, go, kubernetes
- Domain
- cloud, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100