kubernetes-sigs / kubernetes-sigs/node-readiness-controller

Split rule.status.NodeEvaluationResults into a separate CRD NodeReadinessEvaluation

Open
#89 9 comments 0 reactions 1 assignee Claimed by @Karthik-K-N View on GitHub
kind/api-change
Dominant language
Go
Stars
163
Forks
74
Avg merge
2d 18h
Merged PRs (30d)
9

Description

We discussed this in the past about eventually splitting the node evaluation results from the rule status object and while I have been going through the sig-arch api-conventions, I found below guidelines-

> References in the status of the referee to the referrer may be permitted, when the references are one-to-one and do not need to be frequently updated, particularly in an edge-based manner

Our current usage seem to be in conflict with these guidelines, having 1 to many node references in rule status requiring frequent updates.

While having node results directly in the status is nice for observability, this has caused us some concurrency issues that we fixed in the past.

We need to investigate separating the node references into their own. We could decide this after some user feedback or scalability tests.

This applies to three fields - `AppliedNodes`, `FailedNodes`, and `NodeEvaluations` in `NodeReadinessRuleStatus` object.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.